[Part 32] NPC Dialogue Conditions (specifically Jeff & Ben)

[Raunsamsing]

Helpful?

Up

0

::

The reason I set the Location to “6” in the Forest Dialogue is because, it for some reason is the sixth scene in my scene list (has the id “6”). After you sent your dialogues, I immediately switched them out, so I’ve fixed things like Timestamp.DayOfWeek being proceeded as an int instead of a string. This is my “InteractableCharacter” script:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

[RequireComponent(typeof(CharacterMovement))]
public class InteractableCharacter : InteractableObject
{
    public CharacterData characterData;

    //Cache the relationship data of the NPC so we can access it
    NPCRelationshipState relationship;

    //The rotation it should be facing by default
    Quaternion defaultRotation;
    //Check if the LookAt coroutine is currently being executed
    bool isTurning = false;

    CharacterMovement movement;

    private void Start()
    {
        relationship = RelationshipStats.GetRelationship(characterData);

        movement = GetComponent<CharacterMovement>();

        //Cache the original rotation of the character
        defaultRotation = transform.rotation;

        //Add listener
        GameStateManager.Instance.onIntervalUpdate.AddListener(OnIntervalUpdate);
    }

    void OnIntervalUpdate()
    {
        //Get data on its location
        NPCLocationState locationState = NPCManager.Instance.GetNPCLocation(characterData.name);
        movement.MoveTo(locationState);
        StartCoroutine(LookAt(Quaternion.Euler(locationState.facing)));

    }

    public override void Pickup()
    {
        LookAtPlayer();
        TriggerDialogue();
    }

    #region Rotation
    void LookAtPlayer()
    {
        //Get the player's transform
        Transform player = FindObjectOfType<PlayerController>().transform;

        //Get a vector for the direction towards the player
        Vector3 dir = player.position - transform.position;
        //Lock the y axis of the vector so the npc doesn't look up or down to face the player
        dir.y = 0;
        //Convert the direction vector into a quaternion
        Quaternion lookRot = Quaternion.LookRotation(dir);
        //Look at the player
        StartCoroutine(LookAt(lookRot));

    }
    //Coroutine for the character to progressively turn towards a rotation
    IEnumerator LookAt(Quaternion lookRot)
    {
        //Check if the coroutine is already running
        if (isTurning)
        {
            //Stop the coroutine
            isTurning = false;
        }
        else
        {
            isTurning = true;
        }

        while(transform.rotation != lookRot)
        {
            if (!isTurning)
            {
                //Stop coroutine execution
                yield break;
            }

            //Dont do anything if moving
            if (!movement.IsMoving()) transform.rotation = Quaternion.RotateTowards(transform.rotation, lookRot, 720 * Time.fixedDeltaTime);
            yield return new WaitForFixedUpdate();
        }
        isTurning = false;
    }

    //Rotate back to its original rotation
    void ResetRotation()
    {
        StartCoroutine(LookAt(defaultRotation));
    }
    #endregion

    #region Conversation Interactions
    void TriggerDialogue()
    {
        movement.ToggleMovement(false);
        //Check if the player is holding anything
        if (InventoryManager.Instance.SlotEquipped(InventorySlot.InventoryType.Item))
        {
            //Switch over to the Gift Dialogue function
            GiftDialogue();
            return;
        }

        List<DialogueLine> dialogueToHave = characterData.defaultDialogue;

        System.Action onDialogueEnd = () =>
        {
            //Allow for movement
            movement.ToggleMovement(true);
            //Continue going to its destination if it was on the way/Reset its initial position
            OnIntervalUpdate();
        };

        //Have the character reset their rotation after the conversation is over
        //onDialogueEnd += ResetRotation;

        //Do the checks to determine which dialogue to put out

        //Filter through the available dialogues through arbitration
        dialogueToHave = DialogueManager.SelectDialogue(dialogueToHave, characterData.dialogues);

        //Is the player meeting for the first time?
        if (RelationshipStats.FirstMeeting(characterData))
        {
            //Assign the first meet dialogue
            dialogueToHave = characterData.onFirstMeet;
            onDialogueEnd += OnFirstMeeting;

        }

        if (RelationshipStats.IsFirstConversationOfTheDay(characterData))
        {
            onDialogueEnd += OnFirstConversation;
        }

        DialogueManager.Instance.StartDialogue(dialogueToHave, onDialogueEnd);
    }

    //Handle Gift Giving
    void GiftDialogue()
    {
        if (!EligibleForGift()) return;

        //Get the ItemSlotData of what the player is holding
        ItemSlotData handSlot = InventoryManager.Instance.GetEquippedSlot(InventorySlot.InventoryType.Item);

        List<DialogueLine> dialogueToHave = characterData.neutralGiftDialogue;

        System.Action onDialogueEnd = () =>
        {
            //Continue going to its destination if it was on the way/Reset its initial position
            OnIntervalUpdate();

            //Allow for movement
            movement.ToggleMovement(true);

            //Mark gift as given for today
            relationship.giftGivenToday = true;

            //Remove the item from the player's hand
            InventoryManager.Instance.ConsumeItem(handSlot);
        };

        //Have the character reset their rotation after the conversation is over
        //onDialogueEnd += ResetRotation;

        bool isBirthday = RelationshipStats.IsBirthday(characterData);

        //The friendship points to add from the gift
        int pointsToAdd = 0;
        //Do the checks to determine which dialogue to put out
        switch(RelationshipStats.GetReactionToGift(characterData, handSlot.itemData))
        {
            case RelationshipStats.GiftReaction.Like:
                dialogueToHave = characterData.likedGiftDialogue;
                //80
                pointsToAdd = 80;
                if (isBirthday) dialogueToHave = characterData.birthdayLikedGiftDialogue;
                break;

            case RelationshipStats.GiftReaction.Dislike:
                dialogueToHave = characterData.dislikedGiftDialogue;
                //-20
                pointsToAdd = -20;
                if (isBirthday) dialogueToHave = characterData.birthdayDislikedGiftDialogue;
                break;
            case RelationshipStats.GiftReaction.Neutral:
                dialogueToHave = characterData.neutralGiftDialogue;
                //20
                pointsToAdd = 20;
                if (isBirthday) dialogueToHave = characterData.birthdayNeutralGiftDialogue;

                break;
        }
        //Birthday multiplier
        if (isBirthday) pointsToAdd *= 8;


        RelationshipStats.AddFriendPoints(characterData, pointsToAdd);

        DialogueManager.Instance.StartDialogue(dialogueToHave, onDialogueEnd);
    }

    //Check if the character can be given a gift
    bool EligibleForGift()
    {
        //Reject condition: Player has not unlocked this character yet
        if (RelationshipStats.FirstMeeting(characterData))
        {
            DialogueManager.Instance.StartDialogue(DialogueManager.CreateSimpleMessage("You have not unlocked this character yet."));
            return false;
        }

        //Reject condition: Player has already given this character a gift today
        if (RelationshipStats.GiftGivenToday(characterData))
        {
            DialogueManager.Instance.StartDialogue(DialogueManager.CreateSimpleMessage($"You have already given {characterData.name} a gift today."));
            return false;
        }


        return true;
    }

    void OnFirstMeeting()
    {
        //Unlock the character on the relationships
        RelationshipStats.UnlockCharacter(characterData);
        //Update the relationship data
        relationship = RelationshipStats.GetRelationship(characterData);
    }

    void OnFirstConversation()
    {
        Debug.Log("This is the first conversation of the day");
        //Add 20 friend points
        RelationshipStats.AddFriendPoints(characterData, 20);

        relationship.hasTalkedToday = true;
    }
    #endregion
}

[Raunsamsing]

Helpful?

Up

0

::

I just tried my old dialogue system on Ben, and it actually works. I then tried removing one dialogue condition after the other, and found that the problem occurs from the “Shop with 2 Hearts” dialogue, more specifically the “NPCRelationship_Ben.Hearts >= 2” condition. I therefore believe that I am missing something in that script. This was also the problem that prevented me from talking to Abby, so I’m confident that this is the cause. I hope you guys know what I’ve done wrong, so it can be fixed.

[Jonathan Teo]

Helpful?

Up

0

::

In that case the problem probably lies with how nested properties are being handled in the TryGetValueAsString or the GetNestedObject methods in the GameBlackboard script.

[Raunsamsing]

Helpful?

Up

0

::

Well, I’ve earlier been given the entire “GameBlackboard” script by Terence here:

[Part 27] Missing scripts in the video

Could you provide me with the newest version of the script, if it has been changed since?

[Jonathan Teo]

Helpful?

Up

0

::

Hmmm… There shouldn’t be a difference. Are you trying this from loading in a new game after implementing the latest part, or are you doing this from continuing a loaded save before you changed it?

Because after the first cutscene is loaded in, you already should have Ben’s relationship saved and the error should not trigger when you talk to Ben.

[Raunsamsing]

Helpful?

Up

0

::

Yes, I’m loading a new game every time. After the first cutscene with Ben, I also do get a relationship saved, but for some reason it has issues obtaining the correct value. Since you say that nothing is wrong with my scripts, I’m deeply confused at the cause of this. I certainly believe that the condition “NPCRelationship_Ben.Hearts, int, >=, 2” is the correct setup for the condition. It just keeps saying the error: “Object reference not set to an instance of an object GameBlackboard.TryGetValue[T] (System.String key, T& value) (at Assets/Scripts/Game State/GameBlackboard.cs:118)” If it is to any help, when I click the error, it highlights the “Player” object inside of the “Essentials” object. The interaction works if I just delete that singular condition, however, I now also get the error: “No such value AnimalCount found”.

[Jonathan Teo]

Helpful?

Up

0

::

Is your hearts defined in NPCRelationshipState as such: public float Hearts { get { return friendshipPoints / 250; } }

[Raunsamsing]

Helpful?

Up

0

::

Yes, that’s exactly how it’s defined. This is my entire NPCRelationshipState script:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

[System.Serializable]
public class NPCRelationshipState
{
    public string name;
    public int friendshipPoints;

    public bool hasTalkedToday;
    public bool giftGivenToday;

    public NPCRelationshipState(string name, int friendshipPoints)
    {
        this.name = name;
        this.friendshipPoints = friendshipPoints;
    }

    public NPCRelationshipState(string name)
    {
        this.name = name;
        friendshipPoints = 0;
    }

    //Ever 250 friendship points is a heart
    public float Hearts
    {
        get { return friendshipPoints / 250; }
    }

}

[Jonathan Teo]

Helpful?

Up

0

::

In that case Add debug logging in the GetNestedObject method to see exactly what’s failing:

object GetNestedObject(string keys, object parent)
{
    // Add at beginning of method
    Debug.Log($"GetNestedObject trying to access '{keys}' on object type {parent?.GetType().Name ?? "null"}");

    // Rest of method...

    // Add before getting property/field
    Debug.Log($"Looking for '{keyPart}' in {currentObject.GetType().Name}");

    // Add after getting property value
    Debug.Log($"Property value: {property.GetValue(currentObject)}");
}

[Raunsamsing]

Helpful?

Up

0

::

Thanks. So, when trying that (I also had to rename the “Debug()”-function and all the calls to it to avoid an error), it says the following: Ben: Debug.Log 1: “GetNestedObject trying to access ‘Hearts’ on object type NPCRelationshipState” Debug.Log 2: “Looking for ‘Hearts’ in NPCRelationshipState” Debug.Log 3: says “Property not found when this is used: ” if (property != null) { Debug.Log($”Property value: {property.GetValue(currentObject)}”); } else { Debug.Log(“Property not found.”); }” Abby: Debug.Log 1: “GetNestedObject trying to access ‘Hearts’ on object type NPCRelationshipState” Debug.Log 2: “Looking for ‘Hearts’ in NPCRelationshipState” Debug.Log 3: says “Property not found when this is used: ” if (property != null) { Debug.Log($”Property value: {property.GetValue(currentObject)}”); } else { Debug.Log(“Property not found.”); }”

[Jonathan Teo]

Helpful?

Up

0

::

If you were to change the condition to NPCRelationship_Ben.friendshipPoints >= 500, do you get an error?

Also change your debug function to output more details about what’s being stored on the blackboard:

public void DebugDetailed(string context = "")
{
    UnityEngine.Debug.Log($"===== BLACKBOARD DEBUG ({context}) =====");

    foreach(var entry in entries)
    {
        string key = entry.Key;
        object value = entry.Value;

        if (value == null)
        {
            UnityEngine.Debug.Log($"Key: {key} | Value: NULL");
            continue;
        }

        string valueType = value.GetType().Name;
        string valueStr;

        // More detailed output for complex types
        if (value is NPCRelationshipState npcRel)
        {
            valueStr = $"NPCRelationshipState[name={npcRel.name}, friendshipPoints={npcRel.friendshipPoints}, Hearts={npcRel.Hearts}, talked={npcRel.hasTalkedToday}, gift={npcRel.giftGivenToday}]";
        }
        else
        {
            valueStr = value.ToString();
        }

        UnityEngine.Debug.Log($"Key: {key} | Type: {valueType} | Value: {valueStr}");
    }
    UnityEngine.Debug.Log("===== END BLACKBOARD DEBUG =====");
}

And if it helps you can include the context when the blackboard values have changed by having their calls like this blackboard.DebugDetailed($"After unlocking {character.name}"); And post your output here

[Raunsamsing]

Helpful?

Up

0

::

Thanks! When trying NPCRelationship_Ben.friendshipPoints >= 500 I get the exact same error as with >= 2: “InvalidCastException: Specified cast is not valid. GameBlackboard.TryGetValue[T] (System.String key, T& value) (at Assets/Scripts/Game State/GameBlackboard.cs:118)”

The new debug function outputs this when attempting to talk to Ben in the Yodel Ranch (where the bug happens): “===== BLACKBOARD DEBUG () =====” (I didn’t include the context) “Key: Location | Type: Location | Value: YodelRanch” “Key: CurrentlyIndoor | Type: Boolean | Value: True” “Key: Timestamp | Type: GameTimestamp | Value: GameTimestamp” “Key: CutsceneIntroduction | Type: Boolean | Value: True” “Key: PlayerName | Type: String | Value: Bob” “Key: NPCRelationship_Ben | Type: NPCRelationshipState | Value: NPCRelationshipState[name=Ben, friendshipPoints=0, “Hearts=0, talked=False, gift=False]” “===== END BLACKBOARD DEBUG =====”

When attempting to talk to Abby, it says: “===== BLACKBOARD DEBUG () =====” (I didn’t include the context) “Key: Location | Type: Location | Value: Town” “Key: CurrentlyIndoor | Type: Boolean | Value: False” “Key: Timestamp | Type: GameTimestamp | Value: GameTimestamp” “Key: CutsceneIntroduction | Type: Boolean | Value: True” “Key: PlayerName | Type: String | Value: Bob” “Key: NPCRelationship_Ben | Type: NPCRelationshipState | Value: NPCRelationshipState[name=Ben, friendshipPoints=0, Hearts=0, talked=False, gift=False]” “Key: NPCRelationship_Abby | Type: NPCRelationshipState | Value: NPCRelationshipState[name=Abby, friendshipPoints=20, Hearts=0, talked=True, gift=False]” “===== END BLACKBOARD DEBUG =====”

It seems that all the first dialogues work, but thereafter, no dialogue can be had. It also for some reason say that “CutsceneIntroduction” is “True”. Does that mean that it thinks I’m still in the cutscene or what?

[Raunsamsing]

Helpful?

Up

0

::

When avoiding the cutscene (setting the condition for it to be “Location >= 6”), making the debug function not mention that it is in a cutscene, it actually still doesn’t work.

[Jonathan Teo]

Helpful?

Up

0

::

Your location should be = 6, not >= 6 as it is a discrete value.

Would it work if you changed the Value Type of the Hearts/Friendship as a float value instead of an Int?

What version of Unity are you using?

[Raunsamsing]

Helpful?

Up

0

::

Hey. So, the reason I used the condition “Location >= 6” in the Introduction cutscene just was to test if it was the cutscene that caused the problem (which it wasn’t), and I’ve changed it back now.

Changing the Value Type of the friendshipPoints to a float value instead of an int didn’t actually do anything.

I’m on verson 6000.0.42f1.

[Author]

Posts